sorcery icon indicating copy to clipboard operation
sorcery copied to clipboard

Fix/session timeout

Open PedroAugustoRamalhoDuarte opened this issue 3 years ago • 1 comments

Please ensure your pull request includes the following:

  • [ ] Description of changes
  • [ ] Update to CHANGELOG.md with short description and link to pull request
  • [x] Changes have related RSpec tests that ensure functionality does not break

Description

When :remember_me, :session_timeout module are on, the user is not logged out when the first session ends, because session_timeout invalidate the session and remember_me module creates another after that. With this problem we cant logged out a user with timeout when remember_me is on

Solution

Forget remember me token in session_timeout

closes #303

Sorry for the slow response times, been slammed/stressed lately. Haven't forgotten about this, but haven't had the mental bandwidth to tackle it either. Will hopefully get this fixed and tackle the other open issues in the near future, once I'm caught up on other things.

joshbuker avatar Mar 23 '22 00:03 joshbuker

Hello @joshbuker, would you mind checking this issue again?

10 months... Yikes, my bad.

Yeah, adding this to my priority task list.

joshbuker avatar Jan 10 '23 20:01 joshbuker

Thanks for your patience :heart:

Depressingly, even my priority task list is hilariously backlogged.

joshbuker avatar Feb 08 '23 23:02 joshbuker

Thank you for the review, I will improve this specs next week and test a little bit more. This line Timecop.travel(Time.now.in_time_zone + 0.6) looks like magic, i will try to explicit setup the session timeout for make the specs easier to read

@joshbuker @jankoegel closing to resolve in https://github.com/Sorcery/sorcery/pull/358