Soni L.

Results 513 comments of Soni L.

uh, actually we believe this is a bug! think this got overlooked during the implementation of EHv3 (cc @keithw ) further, we believe this code technically triggers UB, ref.: https://www.iso-9899.info/n1570.html#7.13.1.1

EHv3 is deprecated and will be removed some time in the future, the interpreter supports EHv4 these days.

right, so https://github.com/WebAssembly/wabt/blob/ea193b40d6d4a1a697d68ae855b2b3b3e263b377/src/binary-reader-ir.cc#L94-L97 ... we would never have found these if you hadn't mentioned them. (... why aren't they in a header??? or, alternatively, configurable by the user.) it is...

we feel like making them configurable might be useful given the whole wabt is primarily a developer tool (tho having defaults probably wouldn't hurt), but we mean... maybe. we also...

hmm... we'll think about it.

@sbc100 (rebased, ptal)

oh yeah, we should probably bring it up: an alternative to the funny stuff with locals and `refs_` would be to mark ref locals at function start, which would be...

we don't know how complete the interpreter GC (not to be confused with the GC proposal and its implementation) is (how do you even test something like that), but this...

as we were saying, we're not sure if there's a (good) way to test this? as far as we can tell, `Store::Collect` is never called while the interpreter is running,...