Soni L.

Results 397 comments of Soni L.
trafficstars

oh wait did we copy the wrong one

so, with the correct test: ```wast (func (export "break-throw") (result i32) (try $outer (result i32) (do (try (result i32) (do (block $a (try (do (br $a)) (delegate $outer)) ) (call...

hmm what happened in CI?

> +1 on adding tests for `try` + `br`. But the spec tests may not necessarily need to fire the wasm2c bug? If our purpose is testing a `br` within...

it's testing whether the `throw` is going to the correct `catch`/`delegate` and not an unrelated `catch`/`delegate`. for context: wasm2c returns 2.

hmm, with `call` and `throw` variants?

not sure what else to throw into these but this seems like a good starting point.

@aheejin does that break existing functionality? if not, then there's no reason to delay this - further tests can be added later.

oh. uh, is this still relevant? we don't know how the new EH system works, we just know we wrote these for the old system.

oh good it just needed a rebase, nice