eleventy-plugin-sass icon indicating copy to clipboard operation
eleventy-plugin-sass copied to clipboard

Replace node-sass with dart-sass

Open AnalyzePlatypus opened this issue 3 years ago • 5 comments

Closes #26 by switching to the canonical Dart Sass library.

AnalyzePlatypus avatar Jul 12 '21 21:07 AnalyzePlatypus

The current implementation (using node-sass) crashes on macOS Big Sur, which is unsupported by node-sass. This PR fixes that.

AnalyzePlatypus avatar Jul 12 '21 21:07 AnalyzePlatypus

Any news here?

WilNichols avatar Aug 10 '21 00:08 WilNichols

Was just about to do the same. What can we do to see this merged?

nachtfunke avatar Sep 20 '21 18:09 nachtfunke

Pinging @Sonaryr, would you be able to please take a look at this? 🙏 This looks like a relatively simple change. 😄

Not that I care all that much (since I don't have any dependencies on the older node-sass) but it might also make sense to implement a configuration option as well for backward compatibility (i.e. allow user to pass in their preferred compiler). That way maybe it'd see more adoption in case it breaks anything. e.g.

eleventyConfig.addPlugin(require('eleventy-plugin-sass'), {
  // ...
  compiler: require('node-sass'),
  // ...
});

patricknelson avatar Mar 12 '22 01:03 patricknelson

Just created #32 inspired by this pull request which addresses two issues above, i.e.:

  1. Fixes the dependency issue on sass and
  2. Allows you to override via new compiler option in case you still wanted to use node-sass for some reason.

patricknelson avatar Mar 12 '22 04:03 patricknelson