sonarqube-roslyn-sdk
sonarqube-roslyn-sdk copied to clipboard
SonarSource
Replaces the back slash, to allow the zip file to be unzipped in linux
This PR allows the zip file inside the jar file to be unzipped inside linux and windows. During my tests creating containers using linux, the custom analyzer is downloaded but unzipped wrong (the path and filename are considered a full filename instead of directories and filename). During a research, I´ve found the linux can´t unzip directories created with "". It will be unzipped as part of filename.
To resolve the issue and unzip the file on both windows and linux, during the zipping process using System.IO.Compression.ZipArchive, I´ve added a custom encoder which will replace "" to "/" (International convention for directory separation).
We could really use this fix so we don't have to analyze on windows for our .net core projects. +1
@duncanp-sonar Is there anything that needs to be done to help this PR get merged? We are hitting this problem and would love to be able to update our plugin using a supported version of sonarqube-roslyn-sdk.
@Mobrockers @duncanp-sonar we also wait for update as we recently migrated from windows server to linux server +1
This is also blocking our CI from using sonar, would love an update @duncanp-sonar
@cristian-ambrosini-sonarsource @mary-georgiou-sonarsource This issue prevents using SonarQube analysis on Linux/macOs. Please have a look.
Hello everyone! There's a planned hardening for this repository soon. We will examine this issue and PR during that sprint.
@aledaccas Are you interested in finishing this PR? We have a sprint this week to work on this repo.
They have not had any activity on github since 2021 and this pull request is from 2019. I wouldn't hold my breath.
I no longer use sonarqube, I am only following this out of interest.