sonar-dotnet icon indicating copy to clipboard operation
sonar-dotnet copied to clipboard

Fix S2583/S2589 FN: Relational patterns are not supported

Open Tim-Pohlmann opened this issue 1 year ago • 0 comments

void RelationalPattern(int i)
{
    if (i is > 6)
    {
        if (i is > 5)               // FN
            Console.WriteLine();
        if (i > 5)                  // FN
            Console.WriteLine();
    }
    if (i > 6)
    {
        if (i is > 5)               // FN
            Console.WriteLine();
        if (i > 5)                  // Noncompliant
            Console.WriteLine();
    }
}

Reproducers can be found here: https://github.com/SonarSource/sonar-dotnet/blob/69a33d3d99319522e98813aade3e4d920aaccbbd/analyzers/tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/ConditionEvaluatesToConstant.CSharp9.cs#L31-L47

Tim-Pohlmann avatar Oct 31 '23 09:10 Tim-Pohlmann