Add S2933 (`prefer-readonly`) to Sonar way

[yassin-kammoun-sonarsource]

S2933 is in Sonar way for C# but not for TypeScript.

[ilia-kebets-sonarsource]

This rule might be too noisy. It raises thousands of issues on Peach in TS.

[ilia-kebets-sonarsource]

@gabriel-vivas-sonarsource WDYT about adding to the Sonar way?

[gabriel-vivas-sonarsource]

How would it work for JS without type annotations? Actually, I think this would be a good fit for a design/architecture rule. Or maybe I'm missing something?

Regardless, we need to be careful. I suspect this might bring up many many issues in old JS codebases. Also, the rule description would make no sense for JS, we would have to rewrite it completely.

[Wohops]

Migrated to Jira. New ticket number: JS-73