Practical-Logistics icon indicating copy to clipboard operation
Practical-Logistics copied to clipboard

This will give players ability to change size's, chance

Open AnarchySage opened this issue 9 years ago • 5 comments

(should work, 5k errors if i try and boot this local to test)

AnarchySage avatar Jul 05 '16 17:07 AnarchySage

adding things to a config is one thing but you are also seriously reducing the default values: halving the max size and 1/5th the chanse

AEnterprise avatar Jul 05 '16 17:07 AEnterprise

That is true, however he can change the default values, thats what the sapphireOreveinchance = config.get("Maximum sapphire Ore vein chance",5).getInt();

5 value is, its the default, i just chose a low value cause its how i code.

AnarchySage avatar Jul 05 '16 18:07 AnarchySage

yes, but randomely changing values without testing (even if you think the spawn rate is to high) is a bad idea, you're changing balace by a factor of 100 here

AEnterprise avatar Jul 05 '16 18:07 AEnterprise

reverted to previous values with the config

AnarchySage avatar Jul 05 '16 19:07 AnarchySage

@AnarchySage despite your nickname :smile: you should always honor original defaults when you contributing. Mod authors carefully choose these values after a lot of in-game testing, spending a bunch of free time just to figure out what would be the best for the players. If you are disagree with these defaults its OK you can start a debate about it anytime, but you should always honor the effort that the author made to figure out these values. It's true not only for Practical Logistics, but any project in the world.

hron84 avatar Dec 02 '16 12:12 hron84