Flux-Networks icon indicating copy to clipboard operation
Flux-Networks copied to clipboard

Subscribe to world load events with lower priority

Open shartte opened this issue 3 years ago • 3 comments

Hello there,

we have a user reporting a crash interaction between AE2 and your mod due to the following: https://github.com/SonarSonic/Flux-Networks/blob/b3317a3403d3a0e96bbec3a8c0249dcf7941d919/src/main/java/sonar/fluxnetworks/register/CommonEventHandler.java#L67

You load chunks from within the world load event, but do not use lowest priority for your event subscription. This causes - depending on mod loading order - ChunkLoad events to be emitted before the WorldLoad event has been dispatched to other mods, leading to the event order being messed up.

In general I'd advise against this approach since the dedicated server also has not finished setting up all worlds when the event is emitted (i.e. setting difficulty).

shartte avatar Apr 12 '21 18:04 shartte

I see Forge add back their ForgeChunkManager which can solve this

BloCamLimb avatar Apr 13 '21 02:04 BloCamLimb

Temporarily fixed this issue by setting the enableChunkLoading setting in fluxnetworks-common.toml to false

avelizmu avatar May 10 '21 03:05 avelizmu

Did it still not work in 6.1.7?

BloCamLimb avatar May 10 '21 07:05 BloCamLimb