Kirill Bulatov

I will definitely give it a go, but not right now as I have something else planned to be done. If anybody else wants to help with this, please don't...

> the search tab should be a special tab which should never trigger an unsaved state This is wrong, as search/diagnostics/etc. tabs are multibuffers that allow edits — so the...

👋 Upstream curl issue had been fixed, new `curl-sys` version had been released and seems to work on Sonoma. See https://github.com/alexcrichton/curl-rust/issues/524#issuecomment-1753070751 for more details.

It does clean the text, in the file, so not sure what do you mean.

Sorry, it does not look wrong for me and does not fail on `main`@`e68b2d5ecc8076a80d7d8829b8bddf6658367ef3` either: ``` diff --git a/crates/editor/src/editor_tests.rs b/crates/editor/src/editor_tests.rs index 091eca5e8e..c6849b7046 100644 --- a/crates/editor/src/editor_tests.rs +++ b/crates/editor/src/editor_tests.rs @@ -6241,6 +6241,28...

I think I start to understand https://github.com/zed-industries/zed/pull/16423#issuecomment-2296534769 after https://github.com/zed-industries/zed/pull/16423#issuecomment-2296554264 The semantics of the `lsp::TextEdit` is to replace a given range (or insert into a point, if range's start == end)...

On your video, I see on seconds 9 and 10, how an empty file is being saved and got an extra `\n` inside. So > This pr fixes that prevent...

> Your video shows that you tested it with *.rs file and the '\n' inserted by lsp The one that's messed up due to https://github.com/zed-industries/zed/pull/16423#issuecomment-2296640464 as I noted. To restate:...

0. Next time, it would be really beneficial to write a description in the PR, so we do not have to collect the context during reviews. 1. > We can...

I have something that looks like a fix, waiting for the review/confirmation: https://github.com/zed-industries/zed/pull/16654 Meanwhile, using ```json5 "languages": { "Svelte": { // this is a new line "language_servers": ["svelte-language-server", "..."], "prettier":...