Kirill Bulatov

Results 478 comments of Kirill Bulatov

I like the idea and ready to review when it lands + the conflict gets fixed.

The remaining open task is being done in https://github.com/zed-industries/zed/pull/11195 so closing this optimistically.

https://github.com/zed-industries/zed/pull/9813 might have helped with this: now, unless the deleted file was edited in the multibuffer, it should not touch it on save.

re: quick actions, I think https://github.com/zed-industries/zed/pull/8874 could be the culprit. Could you try resolving the actions always here https://github.com/zed-industries/zed/blob/fae5e83d93c9dfc794e0d80e4f9df95b78a576b8/crates/project/src/project.rs#L5415-L5426 and see if that fixes things for you?

Sorry, I am no good with tree-sitter queries, but maybe @maxbrunsfeld can check that out? I have also tried running the same branch locally in better network conditions, ~10x faster...

Oh, looks like queries are much better — can see the methods and even constructors now. One optional note on top: Intellij seems to also include constants into outlines, we...

Thank you for the pointers — it was indeed a malformed JAVA_HOME value, it did download the server after fixing it, but we'd rather mention that in the docs (that...

Looks like it, and speaking of the actions issue, the fix is in `main`

I believe the difference in the behavior you're seeing is due to corresponding language server's `CompletionProvider` not having a `.` in its `triggerCharacters` list. Spec: https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_completion Here are the only...

Hm, the problem is: seems that all 3 mentioned servers do have `.` in their completion providers in `main` branches: * pyright: https://github.com/microsoft/pyright/blob/9dce19cc8761ea8397d41bd7810f52e07f79a252/packages/pyright-internal/src/languageServerBase.ts#L741 * gopls: https://github.com/golang/tools/blob/5bf7d005299769e9d476813f09efd2a4296d5fe9/gopls/internal/server/general.go#L145 * typescript-language-server: https://github.com/typescript-language-server/typescript-language-server/blob/b224b878652438bcdd639137a6b1d1a6630129e4/src/lsp-server.ts#L181 So...