ghost43

Results 513 comments of ghost43

Please rebase against current master, and make sure the CI checks pass.

Yes, naturally we plan to add taproot support. Initially only singlesig wallets with keypath spends will be implemented. To be able to create watch-only versions of these wallets (required before...

I was busy with other things so I did not yet work on this - nor did anyone else AFAICT. It is high on my list however. "it will be...

The immediate cause is now fixed with https://github.com/spesmilo/electrum/pull/7472. I'll leave this open however as clearly there is a larger underlying issue: we rely on version-pinned packages being available from Ubuntu...

That sounds promising. If we switched to a Debian base, I suppose we could pin a snapshot time in the Dockerfile and occasionally update that. Does that sound reasonable? Or...

> One caveat: the docker base image could have issues with the snapshot repo, if the base image is (much) more recent and the snapshot triggers a dependency downgrade We...

Thanks for the PR (https://github.com/spesmilo/electrum/pull/7926)! Now looking at it and thinking about this some more: Re `snapshot.debian.org`, one question that just got me pondering is whether its trustworthiness is comparable...

> So I think we can trust the snapshot as much as we trust the PGP signing key for the main repo (and the strength of the MD5 algo, but...

I think this user tried to name their wallet "ED/46". We should restrict the names to alphanumeric chars.

PyPI (or at least its webserver part) seems to be unreliable recently. I've just tried running `./contrib/freeze_packages.sh` three times in a row, and the first two attempts got different HTTP...