Sergei Solonets

Results 9 comments of Sergei Solonets

Thank you for your answer. It's clear now. I also wounded if you compared FCGF + RANSAC+ICP vs DGR + ICP. I feel that would be an expository comparison.

Dear @Mirmix, thank you for your detailed review. We added much more extensive documentation and fixed some of the problems you mention. Would you be ready to check it out...

> @Solonets @DaniilSinitsyn the comment above from @Mirmix is very relevant (for the paper): > > ``` > I would be glad if the author wrote more about the "delta"...

Hi @jhidalgocarrio, thank you for your effort. There was an undefined behavior in CMake which caused no visualization during the run. I fixed it. Regarding DCMAKE_CXX_STANDARD maybe we could continue...

Hi @Mirmix, thank you for your PR! Regarding the speed: we have the same speed with DSO on the same datasets (even though we have not yet optimized our code...

Hi @Mirmix @jhidalgocarrio, thank you for your review. Right now we **do not make any performance** claims. There is a way to speed it up, and we will work in...

Hi @hugoledoux. Thank you for your feedback. I will answer your questions one by one. 1. We developed the code before in the private repository. I later removed some modules...

Hi @jhidalgocarrio. Thank you for your question. Please check this [description](https://github.com/RoadlyInc/DSOPP/tree/50054d7df1670a35dd33b95a215e89c7e316394b/docs/development_notes.md). Does this answer your question?

Hi @jhidalgocarrio , I am not particularly sure about adding those details to the documentation. You could see the class diagram and description of the classes by compiling code documentation...