awesome-flutter icon indicating copy to clipboard operation
awesome-flutter copied to clipboard

add audioPlayers plugin to readMe - edited source

Open subhash279 opened this issue 4 years ago • 8 comments

Hi,

This plugin provides a simple way to play multiple audio files simultaneously on android and ios. The examples are here - https://github.com/luanpotter/audioplayers. Many features like setting playback rate, showing audio in notification area for ios are available. I think it will be useful to lot of people.

I edited the source file according to the guidelines now.

Thanks,

subhash279 avatar Sep 15 '19 12:09 subhash279

Hi, Just checking if this is merged into the main branch. Thanks!

subhash279 avatar Sep 27 '19 09:09 subhash279

Hi, I resolved any conflicts within the branches. Please merge it if possile. Thanks!

subhash279 avatar Oct 04 '19 11:10 subhash279

Hi @jogboms I am not sure actually why this wasn't merged. It doesn't even have any merge conflicts. Can you pls merge it if possible. Thanks.

subhash279 avatar Nov 04 '19 09:11 subhash279

Hey @subhash279

I mean, at this point, I know both libraries have diverged much but I was just wondering as a fork, why it was never merged back to the source as a PR instead of an entirely new library sharing literally the same name?

PS. you didn't author the library, I know.

jogboms avatar Nov 05 '19 10:11 jogboms

Hi @jogboms I am not entirely sure as you said I am not the author and only a contributor. But I think this has many more features than the original one and I think lots of code was rewritten as well.

subhash279 avatar Nov 05 '19 13:11 subhash279

True. I added the label to look more into it. Thanks

jogboms avatar Nov 05 '19 13:11 jogboms

@jogboms thanks. Also as you may have already noticed it already has more than 460 stars on its own as a new repo.

subhash279 avatar Nov 05 '19 13:11 subhash279

True @subhash279 with a bit more open issues too :)

jogboms avatar Nov 06 '19 10:11 jogboms