solid-ui icon indicating copy to clipboard operation
solid-ui copied to clipboard

Simplify npm script test

Open megoth opened this issue 5 years ago • 5 comments

Today we run npm run build as part of npm test so that Travis is able to run the code properly. I propose we simplify the build-part to only make sure that versionInfo is built, and then modify Travis to do the extra steps necessary to allow it to what it needs to do.

megoth avatar Mar 26 '20 12:03 megoth

As discussed in Slack, I think the second option (modify Travis to do the extra steps necessary to allow it to what it needs to do) and then removing npm run build from npm test altogether, is the best approach.

michielbdejong avatar Mar 26 '20 12:03 michielbdejong

Does it imply that you cannot test locally ?

bourgeoa avatar Mar 26 '20 12:03 bourgeoa

Not really, we can specify in the README that the way to run the tests is:

npm install
npm run build
npm test

michielbdejong avatar Mar 26 '20 12:03 michielbdejong

But yeah, just running npm i && npm test would no longer work.

michielbdejong avatar Mar 26 '20 12:03 michielbdejong

The only thing we need to build in order to make the tests run are versionInfo, so please just change the build-step in test into build-versionInfo or something, and then it should be good.

megoth avatar Mar 26 '20 13:03 megoth