solid-panes icon indicating copy to clipboard operation
solid-panes copied to clipboard

Do Not Show "Log in" or "Sign Up for Solid" buttons when logged in and visiting another Pod

Open brownhoward opened this issue 4 years ago • 3 comments

When logged using my WebID but visiting another Pod, I see "Log In" and "Sign Up for Solid" buttons on the other user's Profile page.

To Replicate

  1. Log into a dev.inrupt.net Pod (e.g., https://khoward5.dev.inrupt.net).
  2. Navigate to another Pod (e.g., https://khoward3.dev.inrupt.net/profile/card#me).
  3. Footer is displayed stating "You're visiting the Pod controlled by Kevin 3. For more info, check out solidproject.org." to show I am visiting the Pod.

Expected Functionality

  1. No option to "Log in" or "Sign Up for Solid" should be offered, as I am already logged in.

Actual Functionality

  1. "Log in" or "Sign Up for Solid" buttons are displayed in the page header and below the Profile.

brownhoward avatar Aug 22 '19 17:08 brownhoward

If your logged into https://khoward5.dev.inrupt.net, and you visit another pods /profile/card#me, you should be able to log in to that pod as an app with your WebID, or to their /public or what ever the .acl is set to, no?

mikeadams1 avatar Aug 22 '19 22:08 mikeadams1

I think this is just an odd UX. If I am already logged in with my WebID and visit another Pod, I would expect to not have Log In and Sign Up options as I cannot be logged into 2 WebIDs simultaneously in the same browser. I would expect the header to still display a Log Out button (to allow me to log out of my own WebID), and for the "Log in" or "Sign Up for Solid" buttons not be displayed below the profile.

On the reverse side, if I was not logged in, and just went to https://khoward3.dev.inrupt.net/profile/card#me, then I would expect to see the "Log in" or "Sign Up for Solid" buttons below the profile.

brownhoward avatar Aug 23 '19 12:08 brownhoward

This is the expected behavior as it currently stands though - https://khoward5.dev.inrupt.net/ and https://khoward3.dev.inrupt.net/ are two different subdomains, so you need to log into each of them separately.

But we could discuss whether or not this should be the behavior. There are some security aspects that enforces this setup now. That said, I agree that it feels weird to log in again and again when you're navigating Pods on the same domain. This is especially the case when you log in to the top-domain of a server (e.g. solid.community) and you have to log in again when you get to your Pod (e.g. megoth.solid.community).

I'll let this issue stay open until we've found out whether this discussion can be facilitated somewhere (perhaps one of the Panels will look into it) or conclude that it needs to stay the way it is.

megoth avatar Aug 23 '19 12:08 megoth