solace-agent-mesh icon indicating copy to clipboard operation
solace-agent-mesh copied to clipboard

fix (DATAGO-118774): Implement validation for imported prompts

Open amir-ghasemi opened this issue 1 month ago • 1 comments

Also addresses:

  • minor issues raised during testing.
  • (DATAGO-118839): Clarify versioning behavior in prompt version history as well

amir-ghasemi avatar Dec 02 '25 03:12 amir-ghasemi

WhiteSource Policy Violation Summary

✅︎ No Blocking Whitesource Policy Violations found in solaceai/solace-agent-mesh-ui-pr-605!

github-actions[bot] avatar Dec 02 '25 03:12 github-actions[bot]

For me, "use in new chat" is not working. It's an update problem.

https://github.com/user-attachments/assets/5fef2ebf-c723-4914-b74a-704c943a735f

rror handled by React Router default ErrorBoundary: Error: Maximum update depth exceeded. This can happen when a component repeatedly calls setState inside componentWillUpdate or componentDidUpdate. React limits the number of nested updates to prevent infinite loops.
    at getRootForUpdatedFiber (react-dom_client.js?v=58c81ad1:2933:128)
    at enqueueConcurrentHookUpdate (react-dom_client.js?v=58c81ad1:2917:16)
    at dispatchSetStateInternal (react-dom_client.js?v=58c81ad1:5449:20)
    at dispatchSetState (react-dom_client.js?v=58c81ad1:5415:9)
    at setRef (chunk-SEHVXYPF.js?v=c50fc377:18:12)
    at chunk-SEHVXYPF.js?v=c50fc377:27:23
    at Array.map (<anonymous>)
    at chunk-SEHVXYPF.js?v=c50fc377:26:27
    at setRef (chunk-SEHVXYPF.js?v=c50fc377:18:12)
    at chunk-SEHVXYPF.js?v=c50fc377:27:23 Error Component Stack
    at DefaultErrorComponent (react-router-dom.js?v=da5136d5:5575:15)
    at RenderErrorBoundary (react-router-dom.js?v=da5136d5:5594:5)
    at DataRoutes (react-router-dom.js?v=da5136d5:6371:3)
    at Router (react-router-dom.js?v=da5136d5:6457:13)
    at RouterProvider (react-router-dom.js?v=da5136d5:6176:11)
    at RouterProvider2 (<anonymous>)
    at AppContent (<anonymous>)
    at TextSelectionProvider (TextSelectionProvider.tsx:19:79)
    at TaskProvider (TaskProvider.tsx:12:61)
    at AudioSettingsProvider (AudioSettingsProvider.tsx:114:82)
    at ProjectProvider (ProjectProvider.tsx:18:76)
    at AuthProvider (AuthProvider.tsx:11:61)
    at ConfigProvider (ConfigProvider.tsx:32:34)
    at CsrfProvider (CsrfProvider.tsx:58:32)
    at ThemeProvider (ThemeProvider.tsx:201:63)

lgh-solace avatar Dec 02 '25 20:12 lgh-solace

Minor UI suggestion: The (X) around the edges are cutoff, perhaps we can give them enough space to appear fully? image

lgh-solace avatar Dec 02 '25 21:12 lgh-solace

Small request? After saving via the dialog, we get 2 toasts, I think we can get rid of the first one? We have an audit open now saying SAM (in general) uses too many toasts.

image

lgh-solace avatar Dec 03 '25 14:12 lgh-solace

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 70%)
17.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube