Sohan Tirpude
Sohan Tirpude
Sure @Kani999.
Hello @Kani999, We have released pyats 24.3 version, so kindly update your branch with latest, execute "make json" again and push your changes again. Thank you.
Hello @Kani999, Kindly pull the latest changes again, update your branch accordingly and try again. I hope you will not see this issue again. Thank you.
Hello @Kani999, As requested by reviewers, kindly add unit tests to your PR. Thank you.
Hello @Kani999, Thanks. Let me check with the reviewers then. Thank you.
Hello @Kani999, Kindly resolve the conflicts in your PR. Thank you.
Hello @Kani999, The conflict is showing in this file: `sdk_generator/outputs/github_parser.json`. Kindly update your branch with latest dev branch and thre re-try again. Thank you.
This issue is still seen
Hello @Kani999, I have checked the PR but it seems you have not addressed the reviewer's comments. So, please address those and let me know once done. Thank you.
Hello @Kani999, Have you checked these comments: https://github.com/CiscoTestAutomation/genieparser/pull/822/files#r1514724904 and https://github.com/CiscoTestAutomation/genieparser/pull/822/files#r1514724716? You have not addressed these comments yet so I don't think the reviewers will approve the PR.