better-docs icon indicating copy to clipboard operation
better-docs copied to clipboard

Upgrade Peer Dep to React 18

Open zedd45 opened this issue 2 years ago • 2 comments

RE #227

  • upgrades peer dep
  • updates reactDOM.render to reactDOM.createRoot

PLEASE NOTE: The tests passed, but npm i failed:

npm i
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   peer react@"18.x.x" from the root project
npm ERR!   peer react@"^0.13.0 || ^0.14.0 || ^15.0.1 || ^16.0.0 || ^17.0.0" from [email protected]
npm ERR!   node_modules/react-ace
npm ERR!     react-ace@"^9.5.0" from the root project
npm ERR!   2 more (react-dom, react-frame-component)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"18.x.x" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/react
npm ERR!   peer react@"18.x.x" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See ./eresolve-report.txt for a full report.

#...

zedd45 avatar Nov 09 '22 19:11 zedd45

Why is it still in draft?..

kirdiapin-n avatar Feb 08 '23 16:02 kirdiapin-n

This is still an issue as I'm working on a project with React 18 and cannot install due to old dependency.

AYColumbia avatar Aug 25 '23 13:08 AYColumbia