Handle dead symlink in upload.

[dennis-sig]

[github-actions[bot]]

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your Sigrid objective of 3.5 stars

Sigrid compared your code against the baseline of 2023-10-31.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 28 refactoring candidates were introduced or got worse.

Risk	System property	Location
🟠	Unit Complexity (Introduced)	src/sigrid_api_client.py SigridApiClient.retry(operation,attempts,allow404,allowEmpty)
🟠	Module Coupling (Introduced)	src/report.py
🟡	Unit Size (Introduced)	src/generate_reports.py generate_reports.py:generateReports(feedbackFile,options,outputDir)
🟡	Unit Size (Introduced)	src/generate_reports.py generate_reports.py
🟡	Unit Size (Introduced)	src/ascii_art_report.py AsciiArtReport.generate(analysisId,feedback,options)
🟡	Unit Size (Introduced)	src/static_html_report.py StaticHtmlReport.renderHtmlFeedback(template,feedback,options)
🟡	Unit Size (Introduced)	src/sigrid_api_client.py SigridApiClient.retry(operation,attempts,allow404,allowEmpty)
🟡	Unit Size (Introduced)	src/sigrid_api_client.py SigridApiClient.callSigridAPI(path,body,contentType)
🟡	Unit Size (Introduced)	src/system_upload_packer.py SystemUploadPacker.prepareUpload(outputFile)
🟡	Unit Size (Introduced)	src/markdown_report.py MarkdownReport.renderMarkdown(analysisId,feedback,options)
🟡	Unit Complexity (Introduced)	src/system_upload_packer.py SystemUploadPacker.isIncluded(filePath)
🟡	Unit Complexity (Introduced)	src/system_upload_packer.py SystemUploadPacker.prepareUpload(outputFile)
🟡	Unit Complexity (Introduced)	src/objective.py Objective.determineStatus(feedback,options)
🟡	Unit Interfacing (Introduced)	src/report.py Report.generate(analysisId,feedback,options)
🟡	Unit Interfacing (Introduced)	src/report.py Report.formatRating(ratings,metric,naText)
🟡	Unit Interfacing (Introduced)	src/json_report.py JsonReport.generate(analysisId,feedback,options)
🟡	Unit Interfacing (Introduced)	src/generate_reports.py generate_reports.py:generateReports(feedbackFile,options,outputDir)
🟡	Unit Interfacing (Introduced)	src/ascii_art_report.py AsciiArtReport.generate(analysisId,feedback,options)
🟡	Unit Interfacing (Introduced)	src/static_html_report.py StaticHtmlReport.generate(analysisId,feedback,options)
🟡	Unit Interfacing (Introduced)	src/static_html_report.py StaticHtmlReport.renderHtmlFeedback(template,feedback,options)
🟡	Unit Interfacing (Introduced)	src/sigrid_api_client.py SigridApiClient.retry(operation,attempts,allow404,allowEmpty)
🟡	Unit Interfacing (Introduced)	src/sigrid_api_client.py SigridApiClient.callSigridAPI(path,body,contentType)
🟡	Unit Interfacing (Introduced)	src/junit_format_report.py JUnitFormatReport.generate(analysisId,feedback,options)
🟡	Unit Interfacing (Introduced)	src/pipeline_summary_report.py PipelineSummaryReport.generate(analysisId,feedback,options)
🟡	Unit Interfacing (Introduced)	src/pipeline_summary_report.py PipelineSummaryReport.printConclusionMessage(feedback,options,status)
🟡	Unit Interfacing (Introduced)	src/markdown_report.py MarkdownReport.generate(analysisId,feedback,options)
🟡	Unit Interfacing (Introduced)	src/markdown_report.py MarkdownReport.renderMarkdown(analysisId,feedback,options)
🟡	Module Coupling (Introduced)	src/upload_log.py

📚 Remaining technical debt

0 refactoring candidates didn't get better or worse, but are still present in the code you touched.

Sigrid ratings

System property	Baseline on 2023-10-31	New/changed code
Volume	(N/A)	N/A
Duplication	(N/A)	5.5
Unit Size	(N/A)	4.3
Unit Complexity	(N/A)	3.8
Unit Interfacing	(N/A)	2.0
Module Coupling	(N/A)	3.1
Component Independence	(N/A)	N/A
Component Entanglement	(N/A)	N/A
Maintainability	(N/A)	3.8

---

• View this system in Sigrid
• View this Sigrid CI feedback in Sigrid

[dennis-sig]

Fixed by https://github.com/Software-Improvement-Group/sigridci/pull/439