sigridci icon indicating copy to clipboard operation
sigridci copied to clipboard

Keep coverage files, even if they are located in the default excludes

Open p3pijn opened this issue 3 years ago • 1 comments

Currently, the folder/target is part of the default excludes. As a consequence, any file in that folder is not published to Sigrid. This is mostly desirable, but typically, coverage reports also end up in these folders. Is there a way to keep these specific files, even if they are part of a folder that is part of the default excludes?

These are the files that would need to be kept:

  • cobertura.xml
  • coverage.xml
  • jacoco.xml
  • lcov.info
  • opencover.xml
  • *.coveragexml
  • mutation-report.json
  • mutations.xml

p3pijn avatar Jun 20 '22 14:06 p3pijn

@p3pijn @Geertien Our main reason for excluding /target/ and its friends is because those directories contain the binaries, which can get pretty huge. We can make the default excludes more specific, but that means we would need to know where the coverage files are created:

  • Jacoco in Maven: target/site/jacoco-aggregate
  • Jacoco in Gradle: build/reports/jacoco
  • Jasmine: coverage/
  • Cobertura: doesn't work anymore in new Java versions, so can't really check
  • opencover.xml: TODO
  • *.coveragexml: TODO
  • mutation-report.json: TODO
  • mutations.xml: TODO

dennis-sig avatar Jun 27 '22 11:06 dennis-sig