bitcode
bitcode copied to clipboard
Support for `time`
Hi, could you consider support for time crate ? I can send a PR if this FR is accepted. Thank you!
- [x]
time::Time - [ ]
time::Duration - [ ]
time::Date
Thanks for the suggestion; we would consider a PR. I think the validation will be relatively challenging (like std::time::Duration but more than one check).
@finnbear Hi, could you also consider adding support for chrono?
We would probably treat chrono equally, since it is similar in features and popularity.
Another library to consider is jiff.
@finnbear Wow, thanks! By the way, if there are plans to add support for rust-decimal, I’ve already submitted a PR. I’m also looking forward to the addition of support for geo-types.
Have a great day!
if there are plans to add support for rust-decimal
The process for supporting library X is:
- if the library doesn't have a precedent for supporting niche encoding crates, skip to step 5
- if
#[derive(Encode, Decode)]is bad for size, speed, or security, skip to step 5 - submit a PR to X with
#[derive(Encode, Decode)] - if the PR is accepted, you're done! otherwise, continue to step 5
- submit a PR to
bitcode - we (usually @caibear) attempt to optimize it
- we might merge it into
bitcode
As per this, I'd probably skip to step 5 for rust_decimal
@finnbear Thank you, I almost made a mistake, haha. I will close the PR I submitted to rust-decimal.