OrcaSlicer
OrcaSlicer copied to clipboard
SoftFever
Fix FanMover and thus filament purge on Bambu Lab P and X series when the "filament speed-up time" feature is used
Description
Fixes "fan speed-up time" and "fan kick-start time" and the problem with FanMover removing the fan stop commands from the filament profiles filament change g-code. Removes the "only overhangs" option from "fan speed-up time" since IMHO it does not make sense to correct fan speed-up latency only for overhangs. Fan latency is fan latency, regardless of extrusion role. The implementation that had been merged in from SuperSlicer couldn't have worked anyway, since the overhang markers checked by FanMover, which is implemented as a g-code filter, are not written into the g-code by OrcaSlicer.
Fixes issues #7639 and #2144.
Tests
I verifyed the produced G-Code by reading it, examined the fan speed view in the layer preview and checked if the filament change g-code from the filament profile is now working correctly.
Hi can we have some updates on this PR? It's a quite nice fix that can instantly benefit lots of users...
Bumping this up on the list. @SoftFever could we maybe explore testing this as part of 2.3.1? This is a long standing issue on the fan mover where ramp up time would break the BBL purge routines.
@shyblower Thanks for the improvement! Could you take a look at the conflicts?
Also, I noticed that there are a lot of changes caused by the format change. Do you mind undoing those changes? That way, it’ll be easier for us to review and track everything.
@SoftFever I know, I unfortunately had my IDE set to do autoformating on save. I'll look into fixing it. There's another issue I found, my fix does does currently not work on the first layer. If a color change happens on the first layer, the cooling fan will be left running at 100% after filament change and thus will affect bed adhesion. Should be easy to fix, though.
Hi @shyblower,
I wanted to check in and see if you’re still interested in working on this PR.
-SoftFever
@SoftFever yes I am, I just had issues concerning my day job which distracted me from my hobbies and currently I'm on vacation in Greece but will be back next week where I will take a closer look at my pull request, try to fix the still remaining problem with the fan delay on multicolor first layers and make it ready for merging.
@SoftFever yes I am, I just had issues concerning my day job which distracted me from my hobbies and currently I'm on vacation in Greece but will be back next week where I will take a closer look at my pull request, try to fix the still remaining problem with the fan delay on multicolor first layers and make it ready for merging.
HI @shyblower
Please enjoy your vacation.
There is no hurry at all.
Take your time whenever it's convenient for you :)