OrcaSlicer
OrcaSlicer copied to clipboard
SoftFever
Add instances
Resolves #632 [FR] Convert from "Cloning" models to "Instances" like PS originally does. , resolves #545 Fill Bed With Instances, resolves #448 [Feature Request]: Add / Remove instances of item like prusa slicer.
For whatever reasons Bamboo dropped instances support. Fortunately they only commented out some code (besides menu creation, I restored it from Prusa), while keeping all instances infrastructures.
Besides usability instances speed up slicing.
Resolves #632 Resolves #2719
@SoftFever please verify and merge this. This is a must for anyone printing in batches
I actually implemented the same thing couple weeks ago lol. Though I did it by adding back the "+" and "-" buttons on the tool bar. I just figured having the buttons are easier.
I can share these changes too if people really want it
Sure, open PR. So I did menu, and you buttons. Both things go well together.
Also resolves #2719 Re-add instancing support for objects on the print bed
@michmela44 is it possible to disable the "autoarrange" when adding instances? It makes creating large arrays of small parts painfully slow. Auto-arrange is a call-it-when needed thing, no?
Possible bug: When you click "add instance", the button becomes unclickable for a brief but variable period of time. If you don't do anything, it goes clickable again with green highlight. But if you happen to click it again while it's unclickable, it stays unclickable until the mouse moves a pixel or two, and only then does the green highlight come back on. Is this a common behavior across UI controls here?
the button becomes unclickable for a brief but variable period of time.
Yes, there is a check whether add instance operation is currently available. Probably it could be optimized.
Yeah the usability issue isn't that it goes unavailable so much as that it requires mouse to move to reactivate in this weird case. I'll try to take a look at that how that button code is working at some point, maybe there's just some UI element state getting reset on failed mode click...
On Mon, Aug 26, 2024, 4:31 AM Vovodroid @.***> wrote:
the button becomes unclickable for a brief but variable period of time.
Yes, there is a check whether add instance operation is currently available. Probably it could be optimized.
— Reply to this email directly, view it on GitHub https://github.com/SoftFever/OrcaSlicer/pull/6237#issuecomment-2309984279, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGVYIPE2IVSD3NHR5DDRTZTMGY3AVCNFSM6AAAAABLMCQN2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMBZHE4DIMRXHE . You are receiving this because you commented.Message ID: @.***>
it requires mouse to move to reactivate
Or click on disable button. Indeed.
Also: In Prusaslicer, you can copy an instance group and get a fresh instance group with a new master instance. This is super useful for people with large numbers of small parts with variations -- I set up a group of 100, place carefully, then copy/paste it and replace the master instance with another part.
But in Orca with this latest PR, copy-pasting a group only pastes the original instance. Here's the result in PrusaSlicer
Just checked and Prusaslicer doesn't appear to make this slow check call on "add instance", at least in 2.7.4.
Actually the whole code of MenuFactory::append_menu_items_instance_manipulation(wxMenu* menu) method is taken from the latest PrusaSlicer.
Interesting! I'll get on the latest PS and see if anything has changed/feels weird.
Added a feature request 6570 to restore the copy/paste behavior of PS in this functionality, too. Really helpful to be able to stamp out big plates of slight variants.
It's kinda working -- instances can be created and removed, and with the right action I have successfully replaced a group of instances with a new part -- but copy/paste of instance groups is still broken, unfortunately, which makes certain kinds of large-scale replication tasks very awkward. But it's at least moving forward!
On Wed, Sep 11, 2024 at 3:43 PM Nikolai @.***> wrote:
Any news on this?
— Reply to this email directly, view it on GitHub https://github.com/SoftFever/OrcaSlicer/pull/6237#issuecomment-2344830399, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGVYLW4E67P2VX4NHDE63ZWDBS3AVCNFSM6AAAAABLMCQN2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUHAZTAMZZHE . You are receiving this because you commented.Message ID: @.***>
@vovodroid @morganvenable @SoftFever Do you guys think this feature could be ready and included with the stable release of orca v2.2?
@vovodroid @SoftFever @Azio-Pantheon @morganvenable Any updates with this?
@vovodroid @morganvenable @SoftFever Do you guys think this feature could be ready and included with the stable release of orca v2.2?
how can we test it? i tried to build this one but i havent environment for this, and got some errors when just fires release_build.bat
is executable somewhere to get?
It's in a dev release, I don't recall the specifics. There's still a ways to go re dealing with arrangement of parts and copy/paste.
For the time being I've reverted to mainline, it's unfortunately difficult to get this together piecemeal because it touches so many different parts of workflow.
On Fri, Oct 25, 2024, 6:33 AM Kuba Miszcz @.***> wrote:
@vovodroid https://github.com/vovodroid @morganvenable https://github.com/morganvenable @SoftFever https://github.com/SoftFever Do you guys think this feature could be ready and included with the stable release of orca v2.2?
how can we test it? i tried to build this one but i havent environment for this, and got some errors when just fires release_build.bat
is executable somewhere to get?
— Reply to this email directly, view it on GitHub https://github.com/SoftFever/OrcaSlicer/pull/6237#issuecomment-2437793764, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGVYJYRF5WLOQIYH7ZJTDZ5JCAZAVCNFSM6AAAAABLMCQN2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZXG44TGNZWGQ . You are receiving this because you were mentioned.Message ID: @.***>
@KubaMiszcz I build it locally on Win10 with VS2022 and build_release_vs2022.bat. I updated PR to the latest main, try to build it again.
@morganvenable actually this PR doesn't existing workflow, so if one doesn't use instances it won't harm. I only added menu and tool bar and uncommented original Prusa code.
Yeah, I was using a random dev build instead of building myself, so I was waaaay off track of current RC :) So... lazy...
On Fri, Oct 25, 2024 at 8:59 AM Vovodroid @.***> wrote:
@KubaMiszcz https://github.com/KubaMiszcz I build it locally on Win10 with VS2022 and build_release_vs2022.bat. I updated PR to the latest main, try to build it again.
@morganvenable https://github.com/morganvenable actually this PR doesn't existing workflow, so if one doesn't use instances it won't harm. I only added menu and tool bar and uncommented original Prusa code.
— Reply to this email directly, view it on GitHub https://github.com/SoftFever/OrcaSlicer/pull/6237#issuecomment-2438200097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAGVYMDM2QJHKHLLSEDEUDZ5JTELAVCNFSM6AAAAABLMCQN2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGIYDAMBZG4 . You are receiving this because you were mentioned.Message ID: @.***>
Please bring this back. This is the only reason I hate using Orca Slicer and I have no idea why Bambu removed it in the first place
Hi, just mentioning this as proper instancing/sharing settings it is something super important, hope that it will be reviewed merged soon!
