OrcaSlicer icon indicating copy to clipboard operation
OrcaSlicer copied to clipboard

fix gizmo bar wobbling

Open buzzhuzz opened this issue 1 year ago • 3 comments

Description

Gizmo bar is wobbling at specific application window width range. This comes from a bar scaling calculations method: - new scale calculated for already scaled bar - scale stored as application settings loosing precision

Rework gizmo bar resizing code to remove feedback: - calculate scale factor based on unscaled bar size

Screenshots/Recordings/Graphs

Screen recording demonstrating the problem

https://github.com/user-attachments/assets/3c8de68d-ef6b-44e9-b41c-5f936047989d

Tests

Manual tests with different window sizes

buzzhuzz avatar Jul 23 '24 14:07 buzzhuzz

i saw many linux users complain about this on discord and reddit. maybe more testers needed also can you check icons are still pixel perfect on regular toolbar size on different window widths related commit with this https://github.com/SoftFever/OrcaSlicer/pull/4552

yw4z avatar Jul 23 '24 14:07 yw4z

I've had a similar issue on MacOS. Will test this, thank you for the effort in fixing it!!!

igiannakas avatar Jul 23 '24 15:07 igiannakas

It works but on Mac OS it makes the bar too small:

image

igiannakas avatar Jul 23 '24 16:07 igiannakas

@igiannakas , thanks for your testing

@yw4z, thanks for your comment. Looking at your changes I see that windows builds are still broken.

I'll update PR once fix MacOS and Windows builds.

buzzhuzz avatar Jul 24 '24 00:07 buzzhuzz

Upon code studying I found that #4552 only affects windows build. After that I've installed windows test VM, download Orca release bulid and found that gizmo bar icons are slightly smaller and much sharper:

  • Current Linux implementation: Screenshot from 2024-07-24 16-30-06
  • Updated Linux implemenattion (windows-like): Screenshot from 2024-07-24 16-29-23

Gizmo bar scaling code now unified across all platforms and shall produce exact result across all three.

buzzhuzz avatar Jul 24 '24 11:07 buzzhuzz

Tested on MacOS - think its working well!

igiannakas avatar Jul 25 '24 08:07 igiannakas

Added commentary. Slightly reorganized code to minimize diff output.

buzzhuzz avatar Aug 03 '24 01:08 buzzhuzz

Hi @buzzhuzz

A heads up, both user and I found the flicking is worse after this change. I have reverted the change for now. I have also committed a workaround fix(cbda70a), it seems working fine now.

SoftFever avatar Aug 04 '24 12:08 SoftFever