SoftFever
Icon fixes and improvements
Let me know if you found more issues related icons
TODO
• Paint icons glitches near edges. image with 8x zoom
• Home page > Orca logo
• Home page > Context menu folder icon
• Project page default icon
• pellets.svg ( appears on filament titlebar after pellet extruder enabled )
• tab_multi_active.svg
• Project page > match document icons
• Project page > Sidebar icons
• Menubar > File > Open project > match icon with new "Open project" icon used on home page
• Toolchanger icons
• Revert icon close to text / checkbox on parameters
• Adaptive Pressure advance
AMS icon blurry and rendered with wrong resolution
causes by its using different resolution from other sidebar icons. It uses 18x18 in code but other sidebar elements using 16x16 changed this in code. i was designed icon as 16x16 previously
before
after
BBL printers > Device / Calibration tab > Printer icon blurry
icon not uses correct resolution on code. matched size with icon on device tab
before
after
Search icon looks dimmed
Anti aliasing reduces strength of colors on lines if they diagonal or circular. Thats why icon looks a bit dimmed compared to other icon. I increased line thickness by %20 for search icon to fix this
Tested on windows but anti aliasing might be work differently on other systems. I didnt increased line thickness above 1.2 to reduce chance of looks bolder compared to other icons. Also results might be differently on high dpi screens
I'm not planning to this on all icons but search icon is always visible and one of main elements. so want to fix this for it
before after (change is minor but noticeable on regular usage)
Home Page > new / open buttons
before
after
Home Page > dummy thumbnails
most dummy thumbnail images has a minimal landscape illustrations. i tried a cube like object but it felt so empty. this one looks cool imo
before
after
Home Page > context menu icons
matched style and shape of icons with previously designed icons
before
after
Setup Filaments > Custom Filament Edit Button
before
after
@yw4z
before
after
Please keep these icons they look much better! Especially the red trash bin. The red accent color is just right here and doesn't disturb the overall color scheme.
The new icons make it look pretty dull.
@discip used on same designed icon with other delete / remove icon on UI to keep consistency. Trash icon looks a bit outdated. But i understand your concern about accidentally clicking remove menu item. there is few workaround for this • Using red color while hovering menu item background • Using red colored icon And there is only 2 item on context menu. i dont think you will struggle too much
About folder icon, i will make a redesign for it. keep following process
-
Trash icon looks a bit outdated.
What about an X.
-
• Using red color while hovering menu item background
Combined with 1. this could be the way to go.
-
About folder icon, i will make a redesign for it. keep following process
Let's see what you've got. 😊
@discip i will look a better solution but dont expect much for context menu :) i guess moving remove / open folders to directly on the thumbnail will be better for future. its already used on project thumbnails. probably folder icon will use bottom-right corner. so that will remove possibility of accidental clicks
button will be visible only when hover
i added this to my list but my list a bit long so i cant make it soon
Thank you @yw4z !
Overall looks fine to me.
I have to suggestions:
- I agree with @discip that old icon is more intuitive
- The new open icon is not intuitive. A straight arrow doesn't convey the message well.
@yw4z Have you given up on this PR or do you still plan to implement it at some point? 😊
@discip didnt gave up, just dont have enough time currently. i will continue where i left when i got some
@SoftFever @Noisyfox Completed this commit, ready to review Reverted change on home screen context menu icons, Let me know your thoughts
@yw4z Looks good so far.
I was really excited to see this implemented:
button will be visible only when hover
Is it still on your list?
@yw4z
I just noticed that you may have swapped the document icons .txt and .pdf.
As for what I know the .txt icons are blue and those representing .pdf are most definitely red across the board.
The content doesn't match either. 😅
I only saw this after looking at the latest Merges. @yw4z I prefer the old Edit icon. It depicts the eraser of the pencil better, which gives a better visual cue.
@henrivdr i'm trying to match all icons on UI. Icon not looks great on dark theme currently because background uses wrong color on filament selection window. you can see difference in here (left sidebar).
i will send a pull request later to fix that