OrcaSlicer icon indicating copy to clipboard operation
OrcaSlicer copied to clipboard

Display Commit ID Used for Build in AboutDialog

Open ElectricalBoy opened this issue 1 year ago • 4 comments

This PR adds the commit ID used for build in the AboutDialog. This should be especially useful when determining on what (nightly) build an issue is occurring.

Screenshot

Resolves #5935

ElectricalBoy avatar Jul 06 '24 08:07 ElectricalBoy

-:  --------- > 1:  4ca0b2400 CI: Avoid Linux Asset Name Collision (#5976)
1:  65a3ab748 = 2:  2581038f4 Display commit ID used for build in AboutDialog

ElectricalBoy avatar Jul 06 '24 11:07 ElectricalBoy

While I like the idea, I can't stand the text appears there -_-! Maybe show it only for nightly build?

SoftFever avatar Jul 16 '24 15:07 SoftFever

While I like the idea, I can't stand the text appears there -_-! Maybe show it only for nightly build?

Is there a separate flag that only nightly builds have enabled? Or is it just the layout of things that you are not comfortable with?

ElectricalBoy avatar Jul 17 '24 00:07 ElectricalBoy

I too like revision ID for nightly builds only.

Also, as nightly builds are intended for testing and bug reports, I'd add revision hash as overlay right onto corner of 3D scene view like this (bottom right corner):

Screenshot from 2024-07-22 19-16-09

buzzhuzz avatar Jul 22 '24 14:07 buzzhuzz

While I like the idea, I can't stand the text appears there -_-! Maybe show it only for nightly build?

Is there a separate flag that only nightly builds have enabled? Or is it just the layout of things that you are not comfortable with?

One solution is to use CMake option and preprocess flag, ref to: https://stackoverflow.com/a/10364240 Then in the CI/CD, enable this option if it's a nightly build

SoftFever avatar Jul 30 '24 14:07 SoftFever

@ElectricalBoy I'm closing it for now. Feel free to re-open it whenever you feel ready

SoftFever avatar Aug 11 '24 15:08 SoftFever