OrcaSlicer icon indicating copy to clipboard operation
OrcaSlicer copied to clipboard

Fix Compile Warnings

Open Ocraftyone opened this issue 1 year ago • 1 comments

Description

This PR clears up almost all of the compile warnings generated when building the slicer on Windows. There are still a few signed/unsigned issues, but fixing those would require larger codebase changes. I tried to keep these changes pretty simple.

Tests

Tested on Windows 11

Ocraftyone avatar Jul 01 '24 12:07 Ocraftyone

With warnings you can at least to see build progress)))

vovodroid avatar Jul 01 '24 12:07 vovodroid

@Ocraftyone

I wanted to give a heads-up that I reverted this PR due to some issues I found. It's a bit costly to test and go through all the changes so I decided to revert the change instead.

Issues I found in case you're curious:

  • Auto orientation is no longer working as expected.
  • There are unintended consequences in src/libslic3r/Arrange.cpp.
  • A function call was removed due to a warning about unused return values, but it's still necessary for the code to function correctly.

SoftFever avatar Aug 11 '24 16:08 SoftFever

No problem! I wasn't entirely done with development on this anyway, so I'll continue to work on it when I can 😁

Ocraftyone avatar Aug 11 '24 16:08 Ocraftyone

Probably let's split the task - for instance I guess it's harmless to resolve unreferenced local variable warning.

vovodroid avatar Aug 17 '24 17:08 vovodroid