OrcaSlicer icon indicating copy to clipboard operation
OrcaSlicer copied to clipboard

build on systems with libwebkit2gtk-4.1

Open buzzhuzz opened this issue 10 months ago • 7 comments

Description

Linux distros started removing libwebkit2gtk-4.0 library from their repos. Ubuntu Noble (24.04) is one of them.

Modify Linux deps script to check which version of libwebkit2gtk is available.

This change addresses #5007

Requires https://github.com/SoftFever/Orca-deps-wxWidgets/pull/1 to be integrated first.

Tests

Build on Ubuntu 24.04 Beta Build on Ubuntu 20.04 (through github actions)

buzzhuzz avatar Apr 24 '24 12:04 buzzhuzz

I tried running the AppImage from this PR on Fedora 40 and get the error: libwebkit2gtk-4.0.so.37: cannot open shared object file: No such file or directory

The default lib seems to be webkitgtk6.0 but webkit2gtk4.0 can still be installed

schugabe avatar Apr 26 '24 06:04 schugabe

Purpose of this PR is to make OrcaSlicer compile on such systems.

Contents and behavior of AppImage is not changed here.

buzzhuzz avatar Apr 26 '24 07:04 buzzhuzz

Same for me on kubuntu 24.04. What is surprising is that the appimage doesn't work as well... I thought that Appimages were created to avoid dependancies problems (all are built in the appimage package, like snap or flatpack... but I might be wrong).

mathojojo avatar Apr 27 '24 17:04 mathojojo

This PR only fixes compilation issue.

For the AppImage fixes please check test build from #4616. https://github.com/SoftFever/OrcaSlicer/issues/4616#issuecomment-2079487313

buzzhuzz avatar Apr 27 '24 22:04 buzzhuzz

@buzzhuzz Thanks. I can't imagine what kind of changes are in the new patch file that contains 53,627 lines of changes...

Anyway, please refer to #5184, for changes related to wxWidgets; let's submit PRs there.: https://github.com/SoftFever/Orca-deps-wxWidgets

SoftFever avatar Apr 29 '24 15:04 SoftFever

@SoftFever

Majority of that patch is configure script re-generated by autotools due to updated configure.am

I'll open PR fo Orca-deps-wxWidgets first.

buzzhuzz avatar Apr 30 '24 00:04 buzzhuzz

I'll open PR fo Orca-deps-wxWidgets first.

Thanks.

Majority of that patch is configure script re-generated by autotools due to updated configure.am

I suggest we don't include these changes

SoftFever avatar Apr 30 '24 13:04 SoftFever