OrcaSlicer icon indicating copy to clipboard operation
OrcaSlicer copied to clipboard

Revamp Time Cost Feature

Open cochcoder opened this issue 1 year ago • 7 comments

For whatever reason GitHub decided to close the original PR which was #4392, that's why I reopened it here

EDIT: Forgot to add this: closes #3502

cochcoder avatar Apr 01 '24 23:04 cochcoder

@cochcoder Thank you for your patience.

I'm not very sure about how useful it is, especially since the electricity cost largely depends on the type of filament used. The electricity consumption varies significantly between printing ABS and printing PLA. It's probably more practical to consider the cost within the filament expenses instead. It seems a bit like over-engineering to further break down the costs and clutter the UI.

Hence, I'm inclined not to include the changes.

SoftFever avatar Apr 14 '24 09:04 SoftFever

@cochcoder Thank you for your patience.

I'm not very sure about how useful it is, especially since the electricity cost largely depends on the type of filament used. The electricity consumption varies significantly between printing ABS and printing PLA. It's probably more practical to consider the cost within the filament expenses instead. It seems a bit like over-engineering to further break down the costs and clutter the UI.

Hence, I'm inclined not to include the changes.

Previously, there was a function for calculating the price depending on the amount of plastic used and the operating time of the printer. Now it does not take into account the operating time of the printer. The field where you can specify the price remains in the printer settings, but it does not affect anything.

FillPavS avatar Apr 16 '24 05:04 FillPavS

@cochcoder

Thank you for your patience.

I'm not very sure about how useful it is, especially since the electricity cost largely depends on the type of filament used. The electricity consumption varies significantly between printing ABS and printing PLA. It's probably more practical to consider the cost within the filament expenses instead. It seems a bit like over-engineering to further break down the costs and clutter the UI.

Hence, I'm inclined not to include the changes.

I see where you're coming from, I'm going to mark this as a draft for now, as I want to look into possibly making a more accurate electricity cost calculator, and see how useful this PR would be in the future.

cochcoder avatar Apr 16 '24 17:04 cochcoder

@cochcoder Thank you for your patience.

I'm not very sure about how useful it is, especially since the electricity cost largely depends on the type of filament used. The electricity consumption varies significantly between printing ABS and printing PLA. It's probably more practical to consider the cost within the filament expenses instead. It seems a bit like over-engineering to further break down the costs and clutter the UI.

Hence, I'm inclined not to include the changes.

Previously, there was a function for calculating the price depending on the amount of plastic used and the operating time of the printer. Now it does not take into account the operating time of the printer. The field where you can specify the price remains in the printer settings, but it does not affect anything.

I'm confused on what you mean as the cost calculator in place right now does take the time of the print into account.

cochcoder avatar Apr 16 '24 17:04 cochcoder

@cochcoder Thank you for your patience.

I'm not very sure about how useful it is, especially since the electricity cost largely depends on the type of filament used. The electricity consumption varies significantly between printing ABS and printing PLA. It's probably more practical to consider the cost within the filament expenses instead. It seems a bit like over-engineering to further break down the costs and clutter the UI.

Hence, I'm inclined not to include the changes.

Previously, there was a function for calculating the price depending on the amount of plastic used and the operating time of the printer. Now it does not take into account the operating time of the printer. The field where you can specify the price remains in the printer settings, but it does not affect anything.

I'm confused on what you mean as the cost calculator in place right now does take the time of the print into account.

It used to work, but not now. I can specify any printing cost in the printer settings, even 1000000, but this is not added to the price of plastic in the final calculation.

FillPavS avatar Apr 16 '24 17:04 FillPavS

I'm not having this issue, can you send a screen recording of you replicating this issue?

cochcoder avatar Apr 16 '24 18:04 cochcoder

I'm not having this issue, can you send a screen recording of you replicating this issue?

The built-in screen recording in Windows records only the active window. I had to record it from my phone. I hope it's clear what's going on there) video - https://cloud.mail.ru/public/sLkn/7gRwY8NRi

FillPavS avatar Apr 16 '24 18:04 FillPavS

@FillPavS So sorry for the late response, I've opened a new PR (#5698) to fix this issue

cochcoder avatar Jun 14 '24 01:06 cochcoder