SoftEtherVPN icon indicating copy to clipboard operation
SoftEtherVPN copied to clipboard

src/Cedar/IPC.c: dead code suspected by coverity

Open chipitsine opened this issue 1 year ago • 1 comments

Are you using SoftEther VPN 5.x?

  • [X] Yes, I'm using SoftEther VPN 5.x, not 4.x.

Version

No response

Component

VPN Server

Operating system & version

lnux

Architecture or Hardware model

toaster

Steps to reproduce

*** CID 426619:  Control flow issues  (UNREACHABLE)
/src/Cedar/IPC.c: 989 in IPCSendDhcpRequest()
983                     }
984     
985                     // Keep the CPU waiting
986                     WaitForTubes(tubes, num_tubes, GetNextIntervalForInterrupt(ipc->Interrupt));
987             }
988     
>>>     CID 426619:  Control flow issues  (UNREACHABLE)
>>>     This code cannot be reached: "ipc->DHCPv4Awaiter.IsAwaiti...".
989             ipc->DHCPv4Awaiter.IsAwaiting = false;
990             FreeDHCPv4Data(ipc->DHCPv4Awaiter.DhcpData);
991             ipc->DHCPv4Awaiter.DhcpData = NULL;
992             return NULL;
993     }
994     

✔️ Expected Behavior

No response

❌ Actual Behavior

No response

Anything else?

No response

chipitsine avatar Jun 23 '24 14:06 chipitsine

@hiura2023 , can you please have a look ?

we run coverity analysis daily, today coverity version was updated, it found some new issues, including this one it is related to DHCP

chipitsine avatar Jun 23 '24 14:06 chipitsine