Add new options (hdri, tcmalloc, svt-av1), improve install methods
What does this PR do?
This is still a draft PR containing a few changes and additions to imei.
New options:
--with-tcmalloc- Alternative memory allocator--disable-hdri- Passes--disable-hdrito ImageMagick: improves conversion time--with-svtav1- Disables libaom default AV1 encoder, enabling SVT-AV1 instead - Faster encoder at the cost of file size
checkinstall changes:
I noticed a few make errors in the logs and realized cmake lacks make uninstall. So, the system got tainted with leftovers even when --build-only was set.
The only alternative I found was to set --fstrans AND --install to yes when --build-only was set. fstrans=yes ensures checkinstall doesn't touch our real filesystem, and --install=yes instructs it to install the newly compiled package... it's a bit contradictory, but it's a requirement to compile all the libraries. After everything is ready, these packages are removed again.
Test Plan
Well, it's an ongoing task. I'll provide more details soonish.
Related PRs and Issues
There are a few. I'll check them later.
Have you read the Code of Conduct?
[x] I have read the Code of Conduct
Summary by CodeRabbit
-
New Features
- Introduced a new function for automating the installation of the SVT-AV1 library.
- Added command-line options for enhanced configurability, including support for the SVT-AV1 encoder, TCMalloc, and HDRI.
- Enhanced version information retrieval from both GitHub and GitLab.
-
Bug Fixes
- Improved handling of installation options to ensure correct library configurations.
-
Documentation
- Updated README to include new command-line options and SVT-AV1 version information.
svt-av1 also requires an update of https://github.com/SoftCreatR/imei/blob/main/update_version_info.sh
Walkthrough
The changes introduce a new script imei-svtav1.sh for automating the installation of the SVT-AV1 library, enhancing the existing imei.sh script with new command-line options, including support for the SVT-AV1 encoder. The update_version_info.sh script has been updated to fetch version information from both GitHub and GitLab repositories, allowing for improved version management. Overall, these modifications enhance the configurability and functionality of the scripts involved.
Changes
| Files | Change Summary |
|---|---|
imei-svtav1.sh |
Added install_svtav1 function for automating SVT-AV1 installation, including version checks, downloads, and optional packaging. |
imei.sh |
Updated to version 6.11.4; added --use-svtav1, --with-tcmalloc, --disable-hdri options; modified installation functions to handle new options and call install_svtav1. |
update_version_info.sh |
Modified to support fetching version info from GitHub and GitLab; updated functions to include a new PLATFORM parameter for improved version retrieval. |
README.md |
Updated options section with new command-line options; changed default ImageMagick version; added SVT-AV1 version information. |
Poem
🐇 In the meadow, changes bloom,
Scripts now dance, dispelling gloom.
SVT-AV1, a new delight,
With options bright, they take flight.
GitHub, GitLab, side by side,
Versioning made easy, we take pride! 🌼
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
I pushed a fix in commit <commit_id>, please review it.Generate unit testing code for this file.Open a follow-up GitHub issue for this discussion.
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:@coderabbitai generate unit testing code for this file.@coderabbitai modularize this function.
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.@coderabbitai read src/utils.ts and generate unit testing code.@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.@coderabbitai help me debug CodeRabbit configuration file.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
@coderabbitai pauseto pause the reviews on a PR.@coderabbitai resumeto resume the paused reviews.@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository.@coderabbitai full reviewto do a full review from scratch and review all the files again.@coderabbitai summaryto regenerate the summary of the PR.@coderabbitai resolveresolve all the CodeRabbit review comments.@coderabbitai configurationto show the current CodeRabbit configuration for the repository.@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.
Huh, I found other serious issues with checkinstall + fstrans=yes... :disappointed:
I spent a few hours trying to workaround these issues, but things started to get way too complicated. I'll revert the fstrans changes tomorrow and think of another way to ensure all file dependencies are correctly installed.