Socolin
Socolin
> Maybe I'm wrong, but [the docs](https://kubernetes-sigs.github.io/cloud-provider-azure/topics/loadbalancer/#custom-load-balancer-health-probe) seem to suggest that there is a huge change in behaviour from 1.23 to 1.24, potentially amplifying this issue: > > > For...
To anyone looking for this, I published the provider in the PR in a separate provider. https://registry.terraform.io/providers/Socolin/randombyte/latest ``` resource "randombyte_bytes" "name" { length = 64 } ```
@bendbennett Do you have an ETA on this ?
Thanks for the comments, I pushed a fix for them.
> > Thanks for the comments, I pushed a fix for them. > > Think everything I left looks good, although maybe I obscured a request from Ben for two...
I added 2 tests. I noticed that there are many tests for `keepers` in the `random_password` resource. Should there also be tests for random_bytes? If so, could we share tests...
I added tests for `keepers` but 2 test don't pass and I don't understand why `TestAccResourceBytes_Keepers_Keep_NullMapToNullValue` `TestAccResourceBytes_Keepers_Keep_EmptyMapToNullValue` Do you know why ? @bendbennett
Ok thanks for the explanation, it should now be good to merge I think.
I just saw the build failed (https://github.com/hashicorp/terraform-provider-random/actions/runs/4179417990), I think the reason is that I did not ran `make generate`, it's now done.
I fixed the last review comment