socketcluster-server
socketcluster-server copied to clipboard
server options aren't passed correctly on server.js
Current behaviour
Server options are passed as options
parameter to server.js. They are combinet to let opts
variable via Object.assign
and stored to this.options
. Server.js takes options from let opts
instead of this.options
and this causes many options to be null.
Expected behaviour
Server.js takes options from this.options
which contains combined options from let opts
and options
parameter.
@KaniZ0r This shouldn't be a problem because Object.assign
mutates the original opts object. So this.options === opts
. That said, we can modify the original code to make this more clear. If that's the case, then this is not very high priority but feel free to make a PR.
Did you notice any problems when running the node? Could there be an alternative explanation?