Manager icon indicating copy to clipboard operation
Manager copied to clipboard

Add a coding standards GA to fix code with Laravel Pint.

Open lucasmichot opened this issue 1 year ago • 7 comments

This PR adds a coding standards GA to fix code with Laravel Pint.

It also fixes the code to match those coding standards

lucasmichot avatar Aug 23 '23 09:08 lucasmichot

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (df5e45b) 53.49% compared to head (9f09c8c) 53.49%. Report is 1 commits behind head on master.

Files Patch % Lines
src/Helpers/ConfigRetriever.php 33.33% 2 Missing :warning:
src/OAuth1/AbstractProvider.php 0.00% 2 Missing :warning:
src/ServiceProvider.php 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #221   +/-   ##
=========================================
  Coverage     53.49%   53.49%           
  Complexity       78       78           
=========================================
  Files            10       10           
  Lines           243      243           
=========================================
  Hits            130      130           
  Misses          113      113           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 23 '23 10:08 codecov[bot]

See comments on other PR https://github.com/SocialiteProviders/Providers/pull/1064#pullrequestreview-1597214663

atymic avatar Aug 27 '23 23:08 atymic

Will it run correctly for contributors as well?

atymic avatar Aug 31 '23 10:08 atymic

It should, my only concern is this : https://github.com/stefanzweifel/git-auto-commit-action#commits-made-by-this-action-do-not-trigger-new-workflow-runs

WDYT ?

lucasmichot avatar Aug 31 '23 10:08 lucasmichot

Introducing the PAT solve this.

This PR is ready to be reviewed @atymic

lucasmichot avatar Sep 07 '23 18:09 lucasmichot

Sorry if i wasn't clear @lucasmichot, I meant just run the lint only (not fix) on the pull_request trigger, so we can know if theres issues

atymic avatar Sep 08 '23 00:09 atymic

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Dec 15 '23 06:12 stale[bot]