David Seifert

@ooxi GNUInstallDir is perfectly overridable (that's the point of the GNU conventions). I recommend adding something along the lines of ``` if(WIN32) set(CMAKE_INSTALL_LOCALEDIR "mylocaledir" CACHE STRING "Windows locale dir") GNUInstallDirs_get_absolute_install_dir(CMAKE_INSTALL_FULL_LOCALEDIR...

@ooxi also I dont see the Github review? Did you forget to click `request changes` maybe?

@inode64 one last rebase, then I will merge it, and only do it for the latest ebuild

I'm not sure that changing to sndio over ALSA by default is the right decision, _especially_ on Linux. If you want to use sndio, you should 1. add a configure...

Finally, I see that `sndio` has a `sndio.pc` file, hence requesting it should be done via `pkg-config`.

yes, we package `sndio` in Gentoo, and it also works fine on Linux, but 1. it definitely shouldn't be the default 2. and it will be mutually exclusive with ALSA...

@jvesely in fact, why even keep the Gtk2 option?

Thanks for the report, even though spaces in filenames will never be supported, because it can't work reliably.

also, I think there's one more use of which: https://github.com/tpm2-software/tpm2-tss/blob/master/.ci/coverity.run#L62 Whilst this isn't needed for the build on our side, I think I'd be a good idea to get rid...

we should inherit from clike, agreed