Fix for tokens that charge fees.
Resolves: SNO-1650
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 91.05%. Comparing base (1cf39a2) to head (60f387e).
:warning: Report is 1 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #1636 +/- ##
==========================================
+ Coverage 91.02% 91.05% +0.02%
==========================================
Files 19 19
Lines 903 906 +3
Branches 164 165 +1
==========================================
+ Hits 822 825 +3
Misses 64 64
Partials 17 17
| Flag | Coverage Δ | |
|---|---|---|
| solidity | 91.05% <100.00%> (+0.02%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
I noticed the event:
event AgentFundsWithdrawn(bytes32 indexed agentID, address indexed recipient, uint256 amount);
Is unused through out our code. I am wondering if we should not emit it in the Handler.sol for v1 and v2. We follow this for other events.
I noticed the event:
event AgentFundsWithdrawn(bytes32 indexed agentID, address indexed recipient, uint256 amount);Is unused through out our code. I am wondering if we should not emit it in the
Handler.solfor v1 and v2. We follow this for other events.
That is redundant with the standard ERC-20 Transfer event.