terraform-provider-snowflake icon indicating copy to clipboard operation
terraform-provider-snowflake copied to clipboard

fix: warehouse resource

Open sivchari opened this issue 1 year ago • 15 comments

The following plan was output.

  ~ resource "snowflake_warehouse" "query-2xlarge" {
        id                                  = "DEV_GARNET_WH_QUERY_2XLARGE"
        name                                = "DEV_GARNET_WH_QUERY_2XLARGE"
      ~ warehouse_size                      = "2XLARGE" -> "XXLARGE"
        # (13 unchanged attributes hidden)
    }

I fixed warehouse size definition and fixed Update/Delete resource to save the latest tfstate.

Test Plan

  • [ ] acceptance tests

sivchari avatar Jun 27 '23 11:06 sivchari

/ok-to-test d1956bc09c14313ffb812ea777e39993ef7fc9de

sfc-gh-ngaberel avatar Jun 29 '23 21:06 sfc-gh-ngaberel

Integration tests failure for

github-actions[bot] avatar Jun 29 '23 21:06 github-actions[bot]

/ok-to-test sha=d1956bc09c14313ffb812ea777e39993ef7fc9de

sfc-gh-ngaberel avatar Jun 29 '23 21:06 sfc-gh-ngaberel

Integration tests failure for d1956bc09c14313ffb812ea777e39993ef7fc9de

github-actions[bot] avatar Jun 29 '23 21:06 github-actions[bot]

Integration tests failure for d1956bc09c14313ffb812ea777e39993ef7fc9de

github-actions[bot] avatar Jun 29 '23 22:06 github-actions[bot]

Please rerun 🐱

sivchari avatar Jun 30 '23 05:06 sivchari

@sivchari sorry we were having issues with our CI infrastructure yesterday, it's back to normal now, I should be able to merge this today. :)

sfc-gh-ngaberel avatar Jun 30 '23 16:06 sfc-gh-ngaberel

Integration tests failure for d1956bc09c14313ffb812ea777e39993ef7fc9de

github-actions[bot] avatar Jun 30 '23 16:06 github-actions[bot]

Integration tests failure for d1956bc09c14313ffb812ea777e39993ef7fc9de

github-actions[bot] avatar Jun 30 '23 17:06 github-actions[bot]

/ok-to-test sha=3350642c4f1244282764264a2de4400cf5bcee3f

sfc-gh-ngaberel avatar Jun 30 '23 21:06 sfc-gh-ngaberel

Integration tests failure for 3350642c4f1244282764264a2de4400cf5bcee3f

github-actions[bot] avatar Jun 30 '23 21:06 github-actions[bot]

Integration tests failure for 3350642c4f1244282764264a2de4400cf5bcee3f

github-actions[bot] avatar Jun 30 '23 23:06 github-actions[bot]

Integration tests failure for 3350642c4f1244282764264a2de4400cf5bcee3f

github-actions[bot] avatar Jul 05 '23 17:07 github-actions[bot]

@sfc-gh-swinkler @sfc-gh-ngaberel

Can you merge this ? Thanks.

sivchari avatar Aug 25 '23 08:08 sivchari

Hi @sivchari! Will you introduce the change that @sfc-gh-swinkler has requested?

sfc-gh-asawicki avatar Oct 03 '23 10:10 sfc-gh-asawicki

Closign because warehouse resource was deeply redesigned in v0.93.0.

sfc-gh-asawicki avatar Jul 11 '24 10:07 sfc-gh-asawicki