terraform-provider-snowflake
terraform-provider-snowflake copied to clipboard
feat: transient database
This PR adds support for transient databases (closes #1152).
It was a bit tricky to add this functionality with the current database implementation so I've slightly refactored it to an iterative approach, following how it's done for the schema resource. Hopefully it will make it easier to implement other functionalities. I only modified the code for database and database clone, so database from share and database from replication are still using the old implementation. I've added some extra tests and ran the acceptance tests using a trial snowflake account as suggested in the readme. Also installed the provider locally and did some extra testing, everything seems to be working fine.
Test Plan
- [x] acceptance tests
- [x] added extra unit tests
- [x] install provider locally for extra testing
References
- https://docs.snowflake.com/en/sql-reference/sql/create-database.html#optional-parameters
/ok-to-test sha=977bb93
i actually like this change. the generic resource builder was very confusing and hard to debug. i think we should be refactoring more resources to each have their own builder.
Integration tests success for 977bb93
can you run make docs
to regenerate docs? since you are updating some documentation which is causing check-docs to fail
can you run
make docs
to regenerate docs? since you are updating some documentation which is causing check-docs to fail
sure thing, done
/ok-to-test sha=5c1ae7e
Integration tests success for 5c1ae7e
thank you for your contribution