terraform-provider-snowflake icon indicating copy to clipboard operation
terraform-provider-snowflake copied to clipboard

feat: transient database

Open sebaap opened this issue 2 years ago • 5 comments

This PR adds support for transient databases (closes #1152).

It was a bit tricky to add this functionality with the current database implementation so I've slightly refactored it to an iterative approach, following how it's done for the schema resource. Hopefully it will make it easier to implement other functionalities. I only modified the code for database and database clone, so database from share and database from replication are still using the old implementation. I've added some extra tests and ran the acceptance tests using a trial snowflake account as suggested in the readme. Also installed the provider locally and did some extra testing, everything seems to be working fine.

Test Plan

  • [x] acceptance tests
  • [x] added extra unit tests
  • [x] install provider locally for extra testing

References

  • https://docs.snowflake.com/en/sql-reference/sql/create-database.html#optional-parameters

sebaap avatar Aug 03 '22 17:08 sebaap

/ok-to-test sha=977bb93

sfc-gh-swinkler avatar Aug 12 '22 05:08 sfc-gh-swinkler

i actually like this change. the generic resource builder was very confusing and hard to debug. i think we should be refactoring more resources to each have their own builder.

sfc-gh-swinkler avatar Aug 12 '22 05:08 sfc-gh-swinkler

Integration tests success for 977bb93

github-actions[bot] avatar Aug 12 '22 06:08 github-actions[bot]

can you run make docs to regenerate docs? since you are updating some documentation which is causing check-docs to fail

sfc-gh-swinkler avatar Aug 12 '22 06:08 sfc-gh-swinkler

can you run make docs to regenerate docs? since you are updating some documentation which is causing check-docs to fail

sure thing, done

sebaap avatar Aug 13 '22 10:08 sebaap

/ok-to-test sha=5c1ae7e

sfc-gh-swinkler avatar Aug 16 '22 23:08 sfc-gh-swinkler

Integration tests success for 5c1ae7e

github-actions[bot] avatar Aug 16 '22 23:08 github-actions[bot]

thank you for your contribution

sfc-gh-swinkler avatar Aug 19 '22 07:08 sfc-gh-swinkler