magento2-menu

magento2-menu copied to clipboard

Snowdog\Menu\Model\ResourceModel\Menu\Node afterSave method throws Exception when used with Database Prefix

1

Currently, when installed on an instance with a database prefix, the node saving fails with table 'databasename.snowmenu_customer' not found. This is because `$this->getConnection();` uses a resource that has been instantiated...

antbates91

Add Resource Connection to __construct so that the connection table name comes through with any prefixes

1

Resolves: https://github.com/SnowdogApps/magento2-menu/issues/346 Add Resource Connection to __construct so that the connection table name comes through with any prefixes Currently, when installed on an instance with a database prefix, the node...

antbates91

Dx improvments

1

Hello, first of all, thank you for this very complete module. We have started to integrate it in our magento 2 and we have 2 minor proposals that can greatly...

mokabiwd

Performance issues on large menus, model loaded via repository

1

Hello, We noticed that for bigger menus the GraphQL response is too slow. After some investigation we found that this method https://github.com/SnowdogApps/magento2-menu/blob/develop/Model/GraphQl/Resolver/DataProvider/Node/TypeModel.php#L49 loads whole model via its repository, and later...

ilnytskyi

with this PR it is possible to store arrays within the content-field of the Node-Entity. This is useful if it is required to store more information, than a single string....

rommelfreddy

Unused variables width and height

2

Hello, there are some unused variables. Since I don't know the intention, I did not want to create a PR for removal only. --- ```php $imageWidth = $block->getImageWidth(); $imageHeight =...

Morgy93

Image Upload for Cms Page link

1

Hello, is there a reason why "Cms Page Link" has no image upload feature? It's only for `['category', 'product', 'custom_url']` - why not for all of them? I'd love to...

Morgy93

Removes leftover `console.log()` statement.

Morgy93

Fixes the duplicated annotation for `$block`.

Morgy93