magento2-menu icon indicating copy to clipboard operation
magento2-menu copied to clipboard

Published 20 hours ago • verified publisher icon SnowdogApps

Dublicate do not work correctly

Open chaikivskyi opened this issue 2 years ago • 4 comments

How to reproduce

  1. Create a menu
  2. Add two nodes (or more)
  3. Move the oldest node as a child of the newest
  4. Click duplicate menu

Expected result

All nodes of the menu will be duplicated

Actual result

Child nodes were not created for nodes where the parent id is less than the id of child nodes

chaikivskyi avatar Jun 21 '22 18:06 chaikivskyi

Merge request: https://github.com/SnowdogApps/magento2-menu/pull/248

chaikivskyi avatar Jun 21 '22 21:06 chaikivskyi

Hi @chaikivskyi, thank you for reporting the issue. I was trying to replicate it with the latest menu module version (2.19.0) and magento m2.4.2 and for me menu duplicating works as expected (attaching screen of parent/child nodes in duplicated menu). Could you please try the latest menu tag and check if the issue persists there as well? Screenshot 2022-06-22 at 16 10 56

aborkowskiy avatar Jun 22 '22 14:06 aborkowskiy

Hi @chaikivskyi, thank you for reporting the issue. I was trying to replicate it with the latest menu module version (2.19.0) and magento m2.4.2 and for me menu duplicating works as expected (attaching screen of parent/child nodes in duplicated menu). Could you please try the latest menu tag and check if the issue persists there as well? Screenshot 2022-06-22 at 16 10 56

Yes, I replicated this issue on the latest version of the module. Can you move node 2 as the child of node 3 and try again?

chaikivskyi avatar Jun 22 '22 18:06 chaikivskyi

Thank you for provided steps, now I was able to reproduce the issue. I created an internal ticket DEV-90908, we'll check your PR soon

andrzejborkowski avatar Jun 24 '22 04:06 andrzejborkowski

PR was merged, closing this issue

adamwaclawczyk avatar Sep 28 '22 09:09 adamwaclawczyk