electron-overlay-window icon indicating copy to clipboard operation
electron-overlay-window copied to clipboard

Keep overlay open if a child of the overlay or target is focused

Open hsource opened this issue 2 years ago • 1 comments

Motivation

While working on awakened-poe-trade, I realized that opening up the file selection dialog for picking an image caused the overlay to close. This is because it's a subwindow.

Fix

Don't fire a blur event for children of either the target or overlay.

Testing

Tested target children with TextEdit; overlay children with awakened-poe-trade

Target

https://github.com/SnosMe/electron-overlay-window/assets/2937410/38f6159c-acd1-40fe-aab8-7d7fc0803b19

Overlay

https://github.com/SnosMe/electron-overlay-window/assets/2937410/a2c13ab2-a09c-4c8c-b2bb-2e5fff97dbe5

hsource avatar Dec 07 '23 11:12 hsource

@SnosMe As a heads up - this fixes 1 of the 2 main remaining issues with awakened-poe-trade on Mac

hsource avatar Dec 07 '23 18:12 hsource