awakened-poe-trade icon indicating copy to clipboard operation
awakened-poe-trade copied to clipboard

Published 20 hours ago • verified publisher icon SnosMe

Open settings... WHAT?

Open klownk opened this issue 1 year ago • 5 comments

Dude, you coded a menu with a "settings" option that opens a pop-up that shows a key combination to OPEN settings... It's just amazing how much yogurt can wreak havoc on the brain...

klownk avatar Dec 14 '23 10:12 klownk

Would you be happy if I just removed that hint from tray menu completely?

SnosMe avatar Dec 14 '23 10:12 SnosMe

I hope you're trolling? What do you think about actually opening the settings when you click on "settings" and putting your "hint" (which is actually just a hotkey indication) in the settings itself.

klownk avatar Dec 14 '23 11:12 klownk

If it was that easy it would have been already done. The app is overlay, not a standalone window.

SnosMe avatar Dec 14 '23 11:12 SnosMe

the application yes but the application settings do not need to be an overlay. You're just making your life complicated for nothing.

klownk avatar Dec 14 '23 11:12 klownk

Making two separate windows work differently is work. You are free to fork and make a PR with that change though.

@SnosMe Maybe it would be possible to remove the popup from the rightclick menu and for the line of the menu to show the shortcut directly, it is true that it feels kinds deceptive for the button to show something that is not what the user wants. I'm thinking on something like making the "settings" button non clickable and for it to have written "shift-space in game for settings" or something like that.

enpinzolas avatar Dec 15 '23 19:12 enpinzolas