nodejs-pool icon indicating copy to clipboard operation
nodejs-pool copied to clipboard

Is this a clerical error in readme.md?

Open fanmaomao opened this issue 7 years ago • 3 comments

I followed the guid in readme.md and I encountered a question that puzzled me. In line 116 of the readme.md file reads: pool/feeAddress But in line 215 of the deployment/base.sql file reads: INSERT INTO pool.config (module, item, item_value, item_type, Item_desc) VALUES ('payout', 'feeAddress', '', 'string', 'Address that pool fees are sent to.');

Is this a clerical error in readme.md? or is my misunderstanding?

fanmaomao avatar Apr 19 '18 01:04 fanmaomao

In readme, “You can also edit the values in sample_config.sql, then import them into SQL directly via an update. ...”

bobbieltd avatar Apr 19 '18 11:04 bobbieltd

That's right. But in /sample_config.sql, the module is also payout, i think it should be based on the file, right?

fanmaomao avatar Apr 20 '18 01:04 fanmaomao

I see what you mean. I believe it's a typo in Readme:

pool/feeAddress should read payout/feeAddress

BKdilse avatar Apr 20 '18 06:04 BKdilse