nodejs-pool
nodejs-pool copied to clipboard
Snipa22
More coins
Very abnormal ! LOL ! Why don’t I know all these coins ? Why aren’t there Bitcoin, Ethereum, .. ? Pushing them all is cool ... 😂😂😂 Unbelievable ! This PR is so shit !
Here is not a trash so you can throw your rubbish with unworking and unknown javascripts to it.
They all suck?
On Mar 6, 2018 12:21 PM, "Learner" [email protected] wrote:
Here is not a trash so you can throw your rubbish with unworking and unknown javascripts to it.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Snipa22/nodejs-pool/pull/353#issuecomment-370858863, or mute the thread https://github.com/notifications/unsubscribe-auth/AFaOlqzZEN5xJ1RONqqYqeIlc6Up2W23ks5tbsWqgaJpZM4SfBn0 .
- You changed leafApi, if other pool owners don’t know and update the codes. All pools will crash. It’s non sense name change.
- For coins javascript, some works some need other changes. You haven’t test them and make a rubbish PR.
- Some coins are scam or unknown or shit coins. It will make nodejs-pool officially supporting scam/shit coins.
- Let me guess. You don’t understand all these coins javascript. If you are not sure about anything, don’t make others lab rats to test your things. You can test them at your repo or other repos as a lab.
Anyone want to help me test these? It would be nice if nodejs-pool could support any cryponight coin
On Mar 6, 2018 7:43 PM, "Learner" [email protected] wrote:
- You changed leafApi, if other pool owners don’t know and update the codes. All pools will crash. It’s non sense name change.
- For coins javascript, some works some need other changes. You haven’t test them and make a rubbish PR.
- Some coins are scam or unknown or shit coins. It will make nodejs-pool officially supporting scam/shit coins.
- Let me guess. You don’t understand all these coins javascript. If you are not sure about anything, don’t make others lab rats to test your things. You can test them at your repo or other repos as a lab.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Snipa22/nodejs-pool/pull/353#issuecomment-370981489, or mute the thread https://github.com/notifications/unsubscribe-auth/AFaOlrRyByC5kej2MvhJhxxSKH3xGSYOks5tby0hgaJpZM4SfBn0 .
It looks like ArqTras pulled in the ITNS coin files from my fork, which will not be usable on this repo without also pulling in other dependent changes that I made to the rest of the pool code. The ITNS coin file is not a drop'n'go thing in this situation. Even on ArqTras' fork he didn't pull in my other related changes, which means ITNS is currently unusable on his fork, too.
I imagine many of the other coin files are not as simple as dropping them in place, either. These should be tested before being included. I can state for sure that this PR in its current state won't allow ITNS to be usable.
I can say from experience, forknote based coins require multiple modifications to base nodejs-pool code to function. There is no one size fits all version of nodejs-pool to support shitcoins. Each one is broken in it's own idiotic way, and you have to patch each pool implementation individually for what the crappy devs broke (or didn't fix) in their wallet/daemon code. Patches to fix one coin will likely break the next one, so don't expect to see shitcoins mainlined in Snipa's code.
Interesting.. I'll have to do some testing.. Arq said that many of them are working and that they were testing Intense
On Mar 15, 2018 9:39 AM, "Rhys79" [email protected] wrote:
I can say from experience, forknote based coins require multiple modifications to base nodejs-pool code to function. There is no one size fits all version of nodejs-pool to support shitcoins. Each one is broken in it's own idiotic way, and you have to patch each pool implementation individually for what the crappy devs broke (or didn't fix) in their wallet/daemon code. Patches to fix one coin will likely break the next one, so don't expect to see shitcoins mainlined in Snipa's code.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Snipa22/nodejs-pool/pull/353#issuecomment-373378567, or mute the thread https://github.com/notifications/unsubscribe-auth/AFaOliruj3FB5KvtsH93JGvEYiH-u5Wgks5tem8GgaJpZM4SfBn0 .
@Venthos that true and I can confirm that more changes need to be done for runing that coin (ITNS) and yes it is borrowed from Your repo. On my github I'm working to make deploy bash files to make it easier to install with more than basic sql info. Some of coins need forknote-utils (Bathmat repository really nice) A the moment I have tested all coins that run on https://supportcryptonight.com and some of them need more work to run. Also pool code is forked from moneroocean and still developed with cooperation and many thanks to Him for His great job. My github repo is different than Snippa22. So adding coins to public Snipa22 repo should get also dev coin addresses and Snippas poolDev wallet, for some reasons I use my own wallets there and if someone consider to add it that should be corrected. I'm not full coin coder except few of them.
