Update t_stream.cpp

Open msdiakov opened this issue 1 year ago • 4 comments

fix ms-* stream id

Mar 25 '24 21:03 msdiakov

Do you have an example case where the original code fails? Or if this is porting from Redis the commit that changed it is sufficient.

Mar 26 '24 00:03 JohnSully

I guess it's this upstream commit: https://github.com/redis/redis/commit/21aa1d4b9118bd42d254c7f9e6157c44d8b1a61d

Mar 26 '24 04:03 barbiefan

I believe that upstream change is to make the XADD more robust when an explicit ID is supplied (I am using the auto-generated ID and have not encountered any issues in KeyDB). If you are going to pull those changes, then it is probably a good idea to pull all the other changes as well, not just that snippet.

Apr 01 '24 04:04 keithchew

Yes it looks like we're missing the tests too

Apr 04 '24 20:04 JohnSully