KeyDB icon indicating copy to clipboard operation
KeyDB copied to clipboard

Refactor Code to Use “Replica”

Open JohnSully opened this issue 6 years ago • 4 comments

This tracks renaming any code still using the old master/slave terminology where back compat is not affected.

The older terminology is divisive and that’s not what KeyDB is about. On top of that “Replica” is simply a more descriptive name especially now that replicas can also push changes with Active Replication.

JohnSully avatar Aug 23 '19 22:08 JohnSully

Progress: c15633ea9 252725d50

JohnSully avatar Oct 13 '19 16:10 JohnSully

Hello @JohnSully, I am keen to give this a shot.

However, I noticed that the README refers to a CONTRIBUTING file, which I am unable to locate. Also, the documentation does not seem to talk about contributions, either.

What are the tests that the code changes need to pass? In the root of the repo, I see a series of 'runtest' files. Are they sufficient? Another thing I saw related to this was the ubuntu-test-latest GitHub Action. Is that the test I should be running?

jay-tau avatar Apr 07 '24 21:04 jay-tau

./runtest and ./runtest-cluster are the two main ones.

Theres Snap internal CI that runs more, the public github CI is a bit limited because the free machines only have 2 cores.

JohnSully avatar Apr 08 '24 03:04 JohnSully