BoxFort icon indicating copy to clipboard operation
BoxFort copied to clipboard

Fork resilience has been disabled since the new Meson build

Open MrAnno opened this issue 4 years ago • 2 comments

Shouldn't we re-enable BXF_FORK_RESILIENCE by default?

MrAnno avatar Jan 31 '22 21:01 MrAnno

Leaving it off by default is probably the better default. Fork safety is very delicate and not guaranteed to work on all platforms & pthread implementations, and not all users might decide to use threads necessarily. Even when using threads, all forks are followed by exec() so we don't need to clean up the locks & threads in the children, at maybe the risk to see some deadlocks if there's a programming error in BoxFort.

In any case, this option has risks, and enabling it should come with full awareness of what this means.

Snaipe avatar Feb 01 '22 16:02 Snaipe

Oh, I see. Thank you for the insight.

MrAnno avatar Feb 01 '22 16:02 MrAnno