itertools-ts icon indicating copy to clipboard operation
itertools-ts copied to clipboard
verified publisher icon Smoren

randomfileadded

Open eshant742 opened this issue 10 months ago • 1 comments

random.ts file added in src which implements the required functions

eshant742 avatar Feb 11 '25 11:02 eshant742

Hi @eshant742! Thank you for your PR!

There are a few things that need to be fixed and completed before I can merge it.

  1. You have created objects Stream and AsyncStream in the file random.ts with method rockPaperScissors. Instead, you have to add these methods to the existing Stream and AsyncStream classes (see files stream.ts, async-stream.ts).

  2. Please export the new functions (rockPaperScissors and rockPaperScissorsAsync) in the file index.ts.

  3. The new functions and methods need to be covered by tests, similar to how the previously implemented functions and methods are tested.

If you have any questions, feel free to reach out.

Smoren avatar Feb 13 '25 07:02 Smoren

Hi @eshant742 Do you plan to continue working on this PR?

Smoren avatar Sep 06 '25 09:09 Smoren